Make internal_backend plugins 1st class local pants plugins.

Review Request #1073 - Created Sept. 24, 2014 and submitted

Information
John Sirois
pants
jsirois/internal_backend/cleanup
608
cce58f2...
Reviewers
pants-reviews
dturner-tw, lahosken, patricklaw

This moves wiring-up of the pants_internal backends to pants.ini
and make the (future) role of src/python/pants/bin:pants clear
and distinct from src/python/pants/bin:pants_local_binary.

It also fixes some broken docsite.json paths and adds some
TODOs to nuke 3rdparty/python/dev_only_requirements.txt.

3rdparty/python/dev_only_requirements.txt | 1 +
build-support/bin/publish_docs.sh | 10 +++++-----
build-support/bin/publish_docs_new.sh | 25 ++++++++++---------------
build-support/pants_venv | 3 ++-
pants | 7 ++++---
pants.ini | 14 ++++++--------
src/python/internal_backend/{sitegen => }/BUILD | 8 +++-----
src/python/internal_backend/sitegen/BUILD | 1 -
src/python/pants/bin/BUILD | 50 +++++++++++++++++++++++++++++++-------------------
src/python/pants/docs/docsite.json | 4 ++--
10 files changed, 64 insertions(+), 59 deletions(-)

CI went green here: https://travis-ci.org/pantsbuild/pants/builds/36185854

Publishing still works (publish_docs_new newly re-works)

$ ./build-support/bin/publish_docs.sh
$ ./build-support/bin/publish_docs_new.sh

internal_backend tests still work

$ PANTS_DEV=1 ./pants goal test tests/python/internal_backend_test::
$ rm pants.pex && ./pants goal test tests/python/internal_backend_test::

the local pants.pex contains the internal_backend

$ zipinfo pants.pex | grep internal_backend
-rw-r--r-- 2.0 unx 55 b- defN 14-Sep-24 11:19 internal_backend/init.py
-rw-r--r-- 2.0 unx 0 b- defN 14-Sep-23 14:29 internal_backend/sitegen/init.py
-rw-r--r-- 2.0 unx 123 b- defN 14-Sep-24 11:18 internal_backend/sitegen/init.pyc
-rw-r--r-- 2.0 unx 555 b- defN 14-Sep-23 14:29 internal_backend/sitegen/register.py
-rw-r--r-- 2.0 unx 813 b- defN 14-Sep-24 11:18 internal_backend/sitegen/register.pyc
-rw-r--r-- 2.0 unx 55 b- defN 14-Sep-24 11:19 internal_backend/sitegen/tasks/init.py
-rw-r--r-- 2.0 unx 5749 b- defN 14-Sep-23 14:29 internal_backend/sitegen/tasks/sitegen.py
-rw-r--r-- 2.0 unx 7291 b- defN 14-Sep-24 11:18 internal_backend/sitegen/tasks/sitegen.pyc

The published sdists do not contain the internal_backend

$ ./pants setup_py //src/python/pants:pants-packaged //src/python/pants:test_infra
WARNING! /home/jsirois/dev/3rdparty/jsirois-pants2/dist/pantsbuild.pants.47Hv89/src/pants/docs/conf.py is source but does not belong to a package!
WARNING! /home/jsirois/dev/3rdparty/jsirois-pants2/dist/pantsbuild.pants.47Hv89/src/pants/docs/pagerank.py is source but does not belong to a package!
Running packager against /home/jsirois/dev/3rdparty/jsirois-pants2/dist/pantsbuild.pants-0.0.24
Writing /home/jsirois/dev/3rdparty/jsirois-pants2/dist/pantsbuild.pants-0.0.24.tar.gz
$ tar -tzf dist/pantsbuild.pants-0.0.24.tar.gz | grep internal_backend
$

$ ./pants setup_py //src/python/pants:test_infra
Running packager against /home/jsirois/dev/3rdparty/jsirois-pants2/dist/pantsbuild.pants.testinfra-0.0.24
Writing /home/jsirois/dev/3rdparty/jsirois-pants2/dist/pantsbuild.pants.testinfra-0.0.24.tar.gz
$ tar -tzf dist/pantsbuild.pants.testinfra-0.0.24.tar.gz | grep internal_backend
$

John Sirois
John Sirois
Larry Hosken
John Sirois
John Sirois
John Sirois
John Sirois
John Sirois
John Sirois
John Sirois
John Sirois
John Sirois
John Sirois
Patrick Lawson
John Sirois
John Sirois
Larry Hosken
John Sirois
John Sirois
Review request changed

Status: Closed (submitted)

Loading...