Update interpreter_cache.py to support a repo-wide interpreter requirement.

Review Request #1025 — Created Sept. 13, 2014 and submitted

jcohen
pants
afa2a59...
pants-reviews
patricklaw, wickman

Update interpreter_cache.py to support a repo-wide interpreter requirement.

./pants goal test tests/python/pants_test:all

JC
  1. Monday morning ping

  2. 
      
JC
JS
  1. quick drive-by

  2. This leaks when yielded-to raises. Pants already has the temporary_dir context manager available that handles this: https://github.com/pantsbuild/pants/blob/master/src/python/pants/util/contextutil.py#L50

    1. Thanks for the pointer, updated!

  3. 
      
JC
YA
  1. This will have a huge impact on increasing repeatability of builds across environments- thank you!

  2. 
      
JS
  1. LGTM - small stuff noted.
    I don't work tomorrow so you'll need to get others to patch this in.

    1. Thanks, addressed all of the below.

  2. tests/python/pants_test/python/BUILD (Diff revision 2)
     
     

    alpha

  3. tests/python/pants_test/python/BUILD (Diff revision 2)
     
     

    Also need 'src/python/pants/util:contextutil' now

  4. alpha:

    contextlib
    shutil
    tempfile
    unittest2

  5. If you're using unittest.TestCase style its a bit odd to assert func-test style instead of using self.assertEqual - pick one style for this file.

  6. 
      
JC
PA
  1. Ship It!

  2. 
      
JC
Review request changed

Status: Closed (submitted)

Change Summary:

Andy landed this for me. Thanks Andy!
Loading...