update release.sh and release.rst to include pantsbuild.pants.testinfra
Review Request #1004 - Created Sept. 8, 2014 and submitted
|areitz, benjyw, dturner-tw, ity, jsirois, stuhood|
Moving on, we'll publish two packages at the same time: pantsbuild.pants
and pantsbuild.pants.testinfra to PyPi. While they're sim-released, users
of pants can choose to install pants only if they don't have any
customization to pants thus avoiding the need of writing additional test
cases to which the pantsbuild.pants.testinfra would be helpful.
I'm not the owner of pantsbuild.pants package on PyPi, so all my testing are local:
tested both. For the '-n' dry-run, I've also manually injected some failures at pants, pants_testinfra build stages, as well some failures in their testing commands, to have verified the proper command chaining behavior of the bash script.
It would be nice to maintain a list of package data: target address, extra pip args, test function name - then adding packages to publish means modifying the list only.
This will double upload
pantsbuild.pantsand the setup_py is
--recursive. No harm done afaict, but not ideal. The SetupPy command would need to be fixed to handle multiple targets on the CLI and that wouldn't bee too hard.
Again I'm happy with a TODO / issue.
I think the logical structure should be:
banner "Testing the latest released pantsbuild.pants and pantsbuild.pants.testinfra" && \ ( (...install_pants stuff...) && \ (...install_pants_tests stuff...) )
Right now its:
banner "Testing the latest released pantsbuild.pants and pantsbuild.pants.testinfra" && \ ( (...install_pants stuff...) ) && \ ( (...install_pants_tests stuff...) )
Not a big deal but odd to read as-is.
You might just focus on plural language throughout. I strongly suspect we'll move to many packages. So, for example, maybe: "This page describes how to make a versioned release of the Pants packages."
In master @ https://github.com/pantsbuild/pants/commit/6041b945c70d68304d7a5fd3bdda893da8fd77b7
Please mark this review as submitted.
I'll assume Ity will help you with the initial register of the new package and the 1st release using the new script.