Added source root tests, updated the internal data structure to include a tree.

Review Request #1003 - Created Sept. 8, 2014 and submitted

Information
Eric Ayers
pants
zundel/refactor-source-root
556
30bb55a...
Reviewers
pants-reviews
jsirois, patricklaw

Added source root tests, updated the internal data structure to include a tree to speed up the find() operation.

With 1000+ source roots in our environment, this appears to shave about 5 seconds off of a no-op build.

Retrofitted tests for SourceRoot.
Added new unit tests for SourceRootTree data structure

CI passed at: https://travis-ci.org/pantsbuild/pants/builds/34713735

Issues

  • 0
  • 3
  • 0
  • 3
Description From Last Updated
Eric Ayers
Eric Ayers
John Sirois
Eric Ayers
Eric Ayers
John Sirois
Eric Ayers
John Sirois
Eric Ayers
Review request changed

Status: Closed (submitted)

Change Summary:

commit ec7e133
Patrick Lawson

Could you please add a test that validates that this works when source roots are registered without target constraints? Internally here all of our source roots are registered with zero constraints, and we've seen regressions in SourceRoot before in this tolerance.

Other than that lgtm!

  1. Oops, I didn't realize how late to this CR I was! Sorry!

  2. I added this unit test in https://rbcommons.com/s/twitter/r/1027/ (it passes)

Loading...